fix: stabilize repeated lifecycle effects in landing experience - #46
Open
amberly-d wants to merge 1 commit into
Open
fix: stabilize repeated lifecycle effects in landing experience#46amberly-d wants to merge 1 commit into
amberly-d wants to merge 1 commit into
Conversation
Extracts inline timers, scroll listeners, and fetch/polling logic into dedicated hooks (useVerificationSimulation, useLeaderboardData, useScrolled) with proper cleanup semantics and unmount guards. Closes Proof-Stell#19.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracts inline timers, scroll listeners, and fetch/polling logic from landing page components into dedicated reusable hooks with proper cleanup semantics and unmount guards.
Closes #19
Key Changes
useVerificationSimulationhook: Extracts hero section timer logic (step progression, verified state) withisMountedguard and interval cleanupuseLeaderboardDatahook: Extracts leaderboard fetch + polling logic withAbortControllercancellation andisMountedguarduseScrolledhook: Extracts scroll position tracking with passive listener and cleanupHeroSection,LeaderboardSection,Navbarnow use the new hooks instead of inline effectsTesting
npm run test— all 13 new lifecycle hook tests pass, all existing tests unaffectednpm run build— only pre-existingimport.meta.vitesttype error inerrorHandler.tsType of Change