fix(ci): align deploy workflow with project toolchain and fix failing tests - #602
Open
otobongdev wants to merge 2 commits into
Open
fix(ci): align deploy workflow with project toolchain and fix failing tests#602otobongdev wants to merge 2 commits into
otobongdev wants to merge 2 commits into
Conversation
… tests Align deploy-frontend job to use Node 22, Yarn 4 (Corepack), and correct action versions to unblock the SEV-1 production deploy failure. Fix 18 test files across the frontend and API test suites to pass CI. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the SEV-1 production deploy failure by correcting the CI
deploy workflow to match the project's actual toolchain (Node 22 + Yarn 4
via Corepack) and resolves test failures across the frontend and API
test suites.
Problem
The
deploy-frontendjob in.github/workflows/deploy.ymlused Node 18and npm (
npm ci,npm run build), but the project requires Node 22+and Yarn 4 (Corepack). This caused the production deploy to fail at
SHA
90c0049with no recoverable last-known-good artifact.Separately, multiple test files had accumulated failures from recent
merges (invalid CSP assertions, vi.mock hoisting issues, missing mocks,
Zod validation mismatches, BigInt serialization, etc.), causing CI to
fail on subsequent pushes.
Changes
Deploy workflow (
.github/workflows/deploy.yml)actions/checkoutfrom v4 to v7 across all jobscorepack enablestep before Node setup18.xto22npm ciwithyarn install --immutablenpm run buildwithyarn buildyarn check:setup --warn-onlyvalidation stepmkdir -p sbombefore writesactions/attest-build-provenancefrom v2 to v4create-releasejob to avoid missing artifact references.sha256filesTypecheck fixes (4 files)
BookOpenCheckimport inBuyerLibrary.tsxautoLockSecondsLeft/extendSessioninWalletProviderinitialStateformatXLMimport inhistory/page.tsxgiftPromptmethod inpromptHashClient.tsTest fixes (18 files)
wrapper.test.tsvi.mockhoisting inapi/sitemap.test.tsusingvi.hoisted()sitemap.tsto readAPP_URLinside handler (not module scope)normalizeContentHashnull safety for legacy promptsredisClientmock to unlock and challenge testsCartProviderto testrenderWithProviderswrapperPurchaseButton.test.tsx— add missingpaginationmock, fix error messageunlock.test.ts— use valid Stellar public keys for Zod validationStellarAddressInput.test.tsx— use stateful wrapper for controlled input testingcheckout.test.ts— add missingclassifyContractErrorandformatContractErrorMessagemocksreviewListAndModeration.test.ts— addheadersto request mock, addsetHeaderto responsemarketplaceReadCache.ts— add BigInt serializer forJSON.stringifyPromptCard.test.tsx— update price label assertion for new CurrencyPrice componentTest Results
The 6 remaining failing test files (WalletProvider session persistence, integration tests, network state tests) were already failing on
mainbefore this fix and involve complex mock setup issues unrelated to the deploy failure.Verification
yarn lintpasses (0 errors)yarn buildsucceedsyarn test:frontend— 877/886 passIncident Timeline
Related
deploy.ymlused npm/Node 18 instead of Yarn/Node 22