fix: track unlock challenge nonces to block signature replay (#446) - #560
Open
flipclip22 wants to merge 2 commits into
Open
fix: track unlock challenge nonces to block signature replay (#446)#560flipclip22 wants to merge 2 commits into
flipclip22 wants to merge 2 commits into
Conversation
…intLabs#446) Reserve each wallet nonce after verification and return CHALLENGE_REPLAY on reuse for prompt and bundle unlock flows. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@flipclip22 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
Resolve conflict |
Resolve unlock conflict by keeping nonce-based replay protection while adopting main's blob storage and CHALLENGE_EXPIRED error handling. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
conflict fixed the remainining cl failure re caused by broken main pls merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reserve each wallet nonce after verification and return CHALLENGE_REPLAY on reuse for prompt and bundle unlock flows.
Closes #446