Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite #16

Merged
merged 15 commits into from
Jun 18, 2022
Merged

Rewrite #16

merged 15 commits into from
Jun 18, 2022

Conversation

akisblack
Copy link
Collaborator

No description provided.

@akisblack akisblack closed this Jun 17, 2022
@akisblack akisblack reopened this Jun 17, 2022
@akisblack akisblack closed this Jun 17, 2022
@akisblack akisblack reopened this Jun 17, 2022
@pistasjis
Copy link
Contributor

someones having issues

pistasjis
pistasjis reviewed Jun 17, 2022
View reviewed changes
pistasjis
pistasjis suggested changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@pistasjis pistasjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@pistasjis
Copy link
Contributor

I have some other nitpicks, but I will fix those myself.

pistasjis and others added 2 commits June 17, 2022 21:13
@akisblack akisblack requested a review from pistasjis June 17, 2022 19:19
pistasjis
pistasjis reviewed Jun 17, 2022
View reviewed changes
@pistasjis
Copy link
Contributor

Looks good to me, but that's my personal opinion. I'm not merging just yet, requesting review from another person.

pistasjis
pistasjis approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@pistasjis pistasjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pistasjis pistasjis requested review from Devnol and Midou36O and removed request for Devnol and Midou36O June 17, 2022 19:32
Midou36O
Midou36O requested changes Jun 17, 2022
View reviewed changes
Copy link
Member

@Midou36O Midou36O left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the issues are required to change, some others are quick questions you're free to not answer and mark as resolved

@Midou36O
Copy link
Member

speaking of the projectsegfault logo @Odyssey346 can you provide a .svg image instead of .pngs? those render faster and are recommended for websites as they are scalable.

Midou36O
Midou36O requested changes Jun 17, 2022
View reviewed changes
Copy link
Member

@Midou36O Midou36O left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot a thing:

@pistasjis
Copy link
Contributor

speaking of the projectsegfault logo @Odyssey346 can you provide a .svg image instead of .pngs? those render faster and are recommended for websites as they are scalable.

Fine I'll do it tomorrow

@Midou36O
Copy link
Member

This might sound crazy but can you put the qr code here?
image

Midou36O
Midou36O reviewed Jun 18, 2022
View reviewed changes
Copy link
Member

@Midou36O Midou36O left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good, if you can fix the indentation the latest commit (thanks Vim for fucking up the indentation) that would be nice

@akisblack
Copy link
Collaborator Author

i can fix both remaining issues

@pistasjis
Copy link
Contributor

image
This is fucking disgusting.

@akisblack
Copy link
Collaborator Author

what do you want me to do with it

@pistasjis
Copy link
Contributor

Fix the indentation here.

@pistasjis
Copy link
Contributor

I think we're good here.

@pistasjis pistasjis merged commit b90baa0 into main Jun 18, 2022
@akisblack akisblack deleted the akis/rewrite branch June 18, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Midou36O Midou36O Midou36O requested changes

@pistasjis pistasjis pistasjis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akisblack @pistasjis @Midou36O