Adding script to parse additional timeless jewel passives #76
+375
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wires77
force-pushed
the
timeless-jewel-export
branch
from
1fea317 to
db4ca0a
Compare
|
Not sure why this is showing a ton of unrelated changes even after merging from |
Wires77
force-pushed
the
timeless-jewel-export
branch
from
7ab78af to
363e587
Compare
|
@Wires77 can you confirm this is still supposed to be merged into our branch? Or too out of date by 3.20? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Script to keep https://www.poewiki.net/wiki/Timeless_Jewel up-to-date with ggpk data
Action Taken
Basically uses the same logic as the passive script. Some things can be combined with it, but there is a lot of work to be done on the template side to support the
AlternateTreeVersionsKeyas a column to replicate how the table looks currently.Caveats
This PR is based on #75 as they had necessary spec updates to run the scripts.This PR doesn't yet cover passive skill additions.
This is definitely a WIP PR, as it doesn't really do anything until the templates are updated to include the extra information. However, the passives were added to the wiki, and images moved to the canonical location. See https://www.poewiki.net/wiki/Passive_Skill:Eternal~keystone~1 for an example.