Repopulate cosmetic_type and cosmetic_theme #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvlvllvlvllvlvl
merged commit cffb5c2
into
Project-Path-of-Exile-Wiki:dev
1 check passed
|
The cosmetic_theme field originally from BaseItemTypes.dat held the visual theme of the cosmetic item. So for example, Fire Horns was in the Fire theme. GGG removed that field from BaseItemTypes.dat, and so it's no longer used on the wiki. This other field that you've mapped to cosmetic_theme seems to be something different, but I also see theme tags in there. |
|
|
|
The values in the CurrencyItems column do appear to link to actual themes from that table, for example Fire Horns links to the Fire tag. l can't see anywhere any of the other rows in ShopTag are referenced from, so it's a bit of a mystery what they are doing there.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
The mtx fix from #104
Action Taken
Changes from the earlier pr were applied to the current code and tested.