Skip to content

Conversation

afarber
Copy link
Contributor

@afarber afarber commented Sep 7, 2025

Fix the #7235 by

  • Append FlatBuffers specific commands to scripts/update_dependencies.sh
  • Upgrade FlatBuffers by running git subtree pull to preserve the upstream git log
  • Upgrade Flatbuffer npm version in package.json
  • Update obsolete link in scripts/update_dependencies.sh comment
  • Ignore .gradle folder

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@afarber afarber force-pushed the 7235-upgrade-flatbuffers branch from 458de28 to 61126b6 Compare September 13, 2025 10:37
git-subtree-dir: third_party/flatbuffers
git-subtree-split: 1c514626e83c20fffa8557e75641848e1e15cd5e
@afarber afarber marked this pull request as draft September 13, 2025 11:03
@afarber
Copy link
Contributor Author

afarber commented Sep 13, 2025

I need to improve this PR:

  • The git subtree was not cleanly exexuted
  • New Flatbuffers dropped Javascript support, but we need the features/support/fbresult_generated.js

…/osrm-backend into 7235-upgrade-flatbuffers

# Conflicts:
#	scripts/update_dependencies.sh
#	third_party/flatbuffers/android/.project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant