[WIP] Make affine and space consistent and correct on converting DICOM image to volume image #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transforms Signed-off-by: M Q <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This pull request updates DICOM image to volume conversion to use consistent coordinate space handling and adds GPU support for image stacking operations. The changes focus on making affine and space transformations more accurate when converting DICOM images to volume images.
- Switches from LPS to RAS coordinate space for DICOM series conversion
- Adds CuPy support for GPU-accelerated image concatenation and stacking
- Improves metadata handling with proper None value conversion for batch processing
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| monai/deploy/operators/dicom_series_to_volume_operator.py | Changes coordinate space from LPS to RAS for DICOM conversion |
| monai/deploy/operators/monai_seg_inference_operator.py | Adds CuPy GPU support, improves metadata handling, and updates image stacking functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: M Q <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request is to ensure the volume image have consistent affine and space after it is converted from DICOM instances.
As described in #557 , the affine derived from the DICOM metadata had been switched to give orientation in
RAS+space to correspond to the expectation by the MONAI models/bundles, and the affine was derived from the DICOMImage Orientation Patientmetadata inLPS+. Thespacemetadata was then supposedly to be switched toRASin the code, but due to some confusion (partly due to the fact that the Orientation transform in MONAI v1.5.0 and below had been ignoringspacemetadata), it had not been done only becomes an issue with thespacemetadata now being parsed and handled in MONAI v1.5.1.