Skip to content

Changing utils.py to test_utils.py #8335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

ericspod
Copy link
Member

Related to #8185.

Description

This changes the name of tests/utils.py to tests/test_utils.py to conform to the changes introduced with the daily CICD tests. This is done in #8231 but the change is being pre-merged now to get tests working again while issues are sorted out there. This also includes changes this PR made to that file, and changes anywhere else to correctly import the module.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Eric Kerfoot <[email protected]>
@KumoLiu
Copy link
Contributor

KumoLiu commented Feb 11, 2025

/build

1 similar comment
@KumoLiu
Copy link
Contributor

KumoLiu commented Feb 11, 2025

/build

Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update, LGTM.

@ericspod ericspod enabled auto-merge (squash) February 11, 2025 14:53
@ericspod ericspod merged commit aa5bd06 into Project-MONAI:dev Feb 11, 2025
28 checks passed
@ericspod ericspod deleted the test_utils_change branch February 11, 2025 16:34
Can-Zhao pushed a commit to Can-Zhao/MONAI that referenced this pull request Mar 10, 2025
Related to Project-MONAI#8185.

### Description

This changes the name of `tests/utils.py` to `tests/test_utils.py` to
conform to the changes introduced with the daily CICD tests. This is
done in Project-MONAI#8231 but the change is being pre-merged now to get tests
working again while issues are sorted out there. This also includes
changes this PR made to that file, and changes anywhere else to
correctly import the module.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants