Repository navigation
Add discovery/owned filter conditions - #95
Merged
Merged
Conversation
Adds the loot filter tokens [discovered], [allDiscovered], [owned] and [allOwned], evaluated via the D2Client_GetItemDiscoveryState export (DISCOVERYSTATE_* bitmask) resolved from ProjectDiablo.dll in BH::CheckForPD2, following the same GetProcAddress pattern as the PD2 sound hook. Conditions evaluate to false when the dll is absent. The predicates are variant-group aware and also cover unidentified unique/set drops: those have no file index client-side, so the dll aggregates the state of every grail-eligible variant on the base item's code instead. Rules can now highlight anything not yet discovered/owned and hide drops whose base is fully completed.
[discovered]/[owned] become [anyDiscovered]/[anyOwned], matching the [allDiscovered]/[allOwned] pair so any-vs-all semantics is explicit in filter rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the loot filter tokens [discovered], [allDiscovered], [owned] and [allOwned], evaluated via the D2Client_GetItemDiscoveryState export (DISCOVERYSTATE_* bitmask) resolved from ProjectDiablo.dll in BH::CheckForPD2, following the same GetProcAddress pattern as the PD2 sound hook. Conditions evaluate to false when the dll is absent.
The predicates are variant-group aware and also cover unidentified unique/set drops: those have no file index client-side, so the dll aggregates the state of every grail-eligible variant on the base item's code instead. Rules can now highlight anything not yet discovered/owned and hide drops whose base is fully completed.