-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/7 fetch user profile #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akkkr
wants to merge
12
commits into
master
Choose a base branch
from
feature/7_fetchUserProfile
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f7aed7b
画像をセーブする処理一部だけ書いた
akkkr 45a3f91
名前表示させた
akkkr 1930ca1
エラー出たからコメントアウトした
akkkr 19cc105
画像表示させた
akkkr 1e3bea3
名前と画像を値渡しした
akkkr c932079
コメント付与した
akkkr 1411d90
printを消した
akkkr 24a7926
falseをtrueに変更
akkkr 39f711d
UIImage(data: imageData)!からUIImage(data: imageData) ?? UIImage()に変更
akkkr c273e1a
関数で切り分けた
akkkr a81096f
listenerに変更
akkkr 8bc71b0
Nukeで画像を設定した
akkkr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ | |
// | ||
|
||
import UIKit | ||
import Firebase | ||
|
||
final class EditProfileViewController: UIViewController { | ||
private var presenter: EditProfileViewPresenterProtocol! | ||
|
@@ -14,6 +15,8 @@ final class EditProfileViewController: UIViewController { | |
@IBOutlet weak var changePhotoButton: UIButton! | ||
@IBOutlet weak var nameTextField: UITextField! | ||
|
||
var userName = "" | ||
var profileImage = UIImage() | ||
|
||
override func viewDidLoad() { | ||
super.viewDidLoad() | ||
|
@@ -24,11 +27,9 @@ final class EditProfileViewController: UIViewController { | |
} | ||
|
||
|
||
|
||
func inject(with presenter: EditProfileViewPresenterProtocol) { | ||
self.presenter = presenter | ||
self.presenter.view = self | ||
|
||
} | ||
|
||
func setupNavigationItem() { | ||
|
@@ -42,10 +43,12 @@ final class EditProfileViewController: UIViewController { | |
} | ||
|
||
func setupNameTextField() { | ||
self.nameTextField.text = self.userName | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. presenterにuserを渡すことになるので |
||
self.nameTextField.addBorderBottom(borderWidth: 1.0, color: .gray) | ||
} | ||
|
||
func setupImageView() { | ||
self.imageView.image = self.profileImage | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ここもuserのprofileImageURLを使ってnukeでimageViewの画像を変えたほうがいいです! |
||
self.imageView.layer.cornerRadius = self.imageView.frame.width / 2 | ||
} | ||
|
||
|
@@ -54,28 +57,23 @@ final class EditProfileViewController: UIViewController { | |
print("キャンセルボタンタップされた") | ||
|
||
self.presenter.didTapStopEditProfileButton() | ||
|
||
} | ||
|
||
//TODO: ここでデータをセーブする処理を行う | ||
@objc func tapSaveEditProfileButton() { | ||
print("セーブボタンタップされた") | ||
|
||
self.presenter.didTapSaveEditProfileButton() | ||
|
||
} | ||
|
||
@IBAction func tapChangePhotoButton(_ sender: Any) { | ||
|
||
self.presenter.didTapChangePhotoButton() | ||
} | ||
|
||
|
||
} | ||
|
||
extension EditProfileViewController: EditProfileViewPresenterOutput { | ||
func dismissEditProfileViewController() { | ||
self.dismiss(animated: true, completion: nil) | ||
|
||
} | ||
|
||
func showActionSheet() { | ||
|
@@ -129,7 +127,6 @@ extension EditProfileViewController: EditProfileViewPresenterOutput { | |
self.present(photoPickerVC, animated: true, completion: nil) | ||
} | ||
} | ||
|
||
} | ||
|
||
extension EditProfileViewController: UIImagePickerControllerDelegate, UINavigationControllerDelegate { | ||
|
@@ -145,6 +142,7 @@ extension EditProfileViewController: UIImagePickerControllerDelegate, UINavigati | |
self.imageView.image = pickerImage | ||
picker.dismiss(animated: true) | ||
} | ||
|
||
} | ||
|
||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UserProfileViewControllerからEditProfileViewControllerにへの値渡しはViewBuilderを介して行った方が良いです!
UserProfileViewControllerで
こんな感じになるようにして
EditProfileViewBuilderはこんな感じでしょうか
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
値の受け渡し、もう少し調べてから頑張ります。。