Skip to content

perf(render): memoize PinnedRepos/TopRepos cards and fix stale closure in togglePin #3150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
surya0904shankar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(render): memoize PinnedRepos/TopRepos cards and fix stale closure in togglePin #3150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 27 additions & 25 deletions src/components/TopRepos.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,39 +324,41 @@ export default function TopRepos() {
);
}, []);

const togglePin = async (repoFullName: string) => {
const isPinned = pinnedRepos.includes(repoFullName);
let newPinsArray: string[];

if (isPinned) {
newPinsArray = pinnedRepos.filter(name => name !== repoFullName);
} else {
if (pinnedRepos.length >= 3) {
setPinError("Maximum 3 pins allowed");
return;
}
newPinsArray = [...pinnedRepos, repoFullName];
}

const togglePin = useCallback((repoFullName: string) => {
setPinError(null);

const prevPins = [...pinnedRepos];
setPinnedRepos(newPinsArray);
setPinnedRepos((prevPins) => {
const isPinned = prevPins.includes(repoFullName);
let newPinsArray: string[];

if (isPinned) {
newPinsArray = prevPins.filter((name) => name !== repoFullName);
} else {
if (prevPins.length >= 3) {
setPinError("Maximum 3 pins allowed");
return prevPins;
}
newPinsArray = [...prevPins, repoFullName];
}

try {
const res = await fetch("/api/user/settings", {
fetch("/api/user/settings", {
method: "PATCH",
headers: {
"Content-Type": "application/json",
},
body: JSON.stringify({ pinned_repos: newPinsArray }),
});
if (!res.ok) throw new Error("Failed to update pins");
} catch (err) {
console.error(err);
setPinnedRepos(prevPins);
}
};
})
.then((res) => {
if (!res.ok) throw new Error("Failed to update pins");
})
.catch((err) => {
console.error(err);
setPinnedRepos(prevPins);
});

return newPinsArray;
});
}, []);

const fetchRepos = useCallback(() => {
setLoading(true);
Expand Down