[Feature] : add secure redirects in webhook dispatches#3127
Open
hrshjswniii wants to merge 6 commits into
Open
[Feature] : add secure redirects in webhook dispatches#3127hrshjswniii wants to merge 6 commits into
hrshjswniii wants to merge 6 commits into
Conversation
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the custom webhook dispatch engine to safely traverse HTTP redirects (3xx status codes) up to a limit of 3 hops. It resolves relative location URLs and ensures that SSRF safety checks are performed at each hop's destination before dispatching, preventing delivery failures for webhooks behind URL shorteners or dynamic API gateways.
Closes #3043
Type of Change
What Changed
src/lib/webhooks.ts):dispatchWebhookto follow301,302,303,307, and308redirect headers.new URL(location, currentUrl)to support resolving relative redirect paths.isSafeUrlverification on every target redirect location to prevent SSRF vulnerabilities.test/webhooks.test.ts):/webhook-final).How to Test
Expected result:
All tests pass successfully.
Checklist
console.log, debug code, or commented-out blocksnpm run lintpasses locallynpm run type-check)Additional Context