fix: improve dashboard responsiveness on very small screens#1192
fix: improve dashboard responsiveness on very small screens#1192S-MOHAMMED-ISMAIL wants to merge 7 commits into
Conversation
|
@S-MOHAMMED-ISMAIL is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
CI failure appears unrelated to this PR. The failing Playwright smoke tests are repo-wide and affect multiple existing E2E specs:
This PR only modifies dashboard responsiveness for very small screens (320px layouts). Local lint checks pass successfully. |
|
CI is failing on this PR. Please fix the failing checks before this can be merged. |
|
All requested fixes have been completed and all CI checks are passing. |
6704e1c to
46fc605
Compare
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
Thanks for working on mobile responsiveness! However, this PR goes far beyond the described scope and introduces significant regressions:
Scope creep (GoalTracker.tsx):
- Removes the ConfettiBurst celebration animation
- Removes the
+1manual increment button for non-auto-synced goals - Removes the 'Auto-synced' badge and last-synced timestamp
- Removes 'hours' and 'streak (days)' unit options (replaces with 'issues resolved')
- Removes the recurrence pill selector (replaces with a dropdown)
- Removes the deadline picker from the creation form
- Removes auto-sync hint text
Dashboard layout regressions (page.tsx):
- Removes
WeeklySummaryCard,AIMentorWidget, andPersonalRecordssections entirely - Rearranges the entire grid structure
- There appears to be an extra
</div>tag that would break the HTML structure
What a responsiveness fix should look like:
- Keep all existing features intact
- Add
min-w-0,overflow-hidden, responsive padding (p-4 sm:p-6) - Fix specific overflow/scroll issues on 320px viewports
Please revert all the feature/layout changes and submit only the minimal responsive CSS fixes. Thank you!
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
This PR has 2 merge conflicts with current main (in next.config.mjs and src/app/dashboard/page.tsx which have been significantly updated). Please rebase onto current main and resolve the conflicts.
|
Your PR has conflicts with the current |
d0a7396 to
bff1c13
Compare
…ight and typescript (#1192)
|
Hi, I've addressed the requested changes and updated my branch with the latest main branch. All CI checks, including the Playwright tests, are now passing. Please let me know if any further changes are needed. Thank you! |
Removes overflow-x-hidden that was clipping content on 320px viewports, updates Playwright config and TypeScript settings for better compatibility. Co-authored-by: S-MOHAMMED-ISMAIL <ismailfazi194@gmail.com>
|
Merged manually into main via squash commit with full co-authorship credit. Thank you @S-MOHAMMED-ISMAIL for the contribution! 🎉 |
|
Thank you for merging my contribution and for your guidance throughout the review process. I really appreciate it. Looking forward to contributing to DevTrack again. 🚀 |
Summary
Fixed dashboard responsiveness issues on very small screens (320px devices).
Closes #975
Type of Change
Changes Made
How to Test
Steps for the reviewer to verify this works:
Run the app locally using
npm run devOpen Chrome DevTools → Responsive Mode
Set viewport width to
320pxNavigate to the dashboard page
Verify:
Screenshots (if UI change)
Checklist
npm run lintpasses locallynpm run type-check)