Enable MPS devices on the CI, and fix associated bugs. #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
oscarkey
changed the title
I only enable for the maximum dependency set, because I couldn't get it to work reliably with PyTorch <2.3. But, better than nothing.
oscarkey
requested review from
LeoGrin and
klemens-floege
and removed request for
klemens-floege
|
swapping reviewer because of ooo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only enable for the maximum dependency set, because I couldn't get
it to work reliably with PyTorch <2.3. But, better than nothing to check we work on MacOS.