Skip to content

feat: add vllm-metrics-tui optional dependency and tmux integration#2194

Draft
samsja wants to merge 1 commit intomainfrom
feat/vllm-metrics-tui
Draft

feat: add vllm-metrics-tui optional dependency and tmux integration#2194
samsja wants to merge 1 commit intomainfrom
feat/vllm-metrics-tui

Conversation

@samsja
Copy link
Copy Markdown
Member

@samsja samsja commented Apr 3, 2026

  • Add tui optional dependency group for vllm-metrics-tui
  • Update tmux.sh to auto-discover inference server URLs from logs and launch the metrics TUI in a dedicated window

https://github.com/samsja/vllm-metrics-tui

image

Note

Low Risk
Low risk: changes are limited to packaging metadata and a best-effort tmux helper that only runs when vllm-metrics-tui is installed and matching logs are present.

Overview
Adds a new optional dependency extra, prime-rl[tui], sourcing vllm-metrics-tui from Git to enable a metrics terminal UI.

Updates scripts/tmux.sh to optionally create a Metrics tmux window that auto-discovers vLLM inference server URLs by parsing logs/inference/node_*.log (and resolving 0.0.0.0 hosts via orchestrator.log) and then launches vllm-metrics-tui with the discovered endpoints.

Written by Cursor Bugbot for commit 49d4aa5. This will update automatically on new commits. Configure here.

- Add `tui` optional dependency group for vllm-metrics-tui
- Update tmux.sh to auto-discover inference server URLs from logs
  and launch the metrics TUI in a dedicated window

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@samsja samsja marked this pull request as ready for review April 3, 2026 15:43
@samsja samsja marked this pull request as draft April 3, 2026 15:43
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

if [[ "$url" == *"0.0.0.0"* ]]; then
port=$(echo "$url" | grep -oP ':\d+$')
# Try to find the real hostname from orchestrator logs
host=$(grep -oP "ltc-[a-z0-9-]+${port}" "${LOG_DIR}/orchestrator.log" 2>/dev/null | head -1)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hostname resolution returns same host for all nodes

Medium Severity

In multi-node inference where all servers bind to 0.0.0.0 on the same default port (8000), the grep … | head -1 on each iteration of the for node_log loop always returns the same first matching hostname from the orchestrator log. This means every node resolves to the same URL, so METRICS_URLS contains duplicates of a single server rather than distinct URLs for each inference node. The grep has no per-node correlation — it needs to either track already-matched hosts or use node-specific identifiers.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants