Allow specifying a source by URL and allow using a QML ListModel or another QAbstractListModel-based model #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful if a custom model (like ListModel) is used instead of itemContainer.data, for example, if tabs are added dynamically, like here: `<listModel>.append({..., source: Qt.resolvedUrl(...)})`
previously it would still be possible, but every iitem would need to have all actual data under the 'modelData' field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to implement dynamic tabs loading in my app. I found that it could actually be easier to specify the tab item source by URL instead of a Component. This PR adds support for this.
Additionally, I found that it is easier to put a simple QML ListModel for the
modelproperty for loading tabs dynamically. Current code requires the data to be accessable frommodelDataproperty (which is the case for current system used, for example, in gallery). This PR keeps this but uses properties directly frommodelifmodelDatadoesn't work.