Skip to content

WebP support #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
louisbels wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

WebP support #94

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6316aa7
webp support
louisbels Aug 17, 2023
3266d6f
Merge pull request #1 from patrocle/webp-support
louisbels Aug 17, 2023
c0259a2
WebP support start with Prestashop 8.0.0 min
louisbels Aug 18, 2023
cd9be52
CI prestshop 8.1.0 & php 8.1
louisbels Aug 18, 2023
83debe2
GitHub workflow - check PHP compatibility between 7.2 and 8.1 - check…
louisbels Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ps_imageslider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function __construct()

$this->displayName = $this->trans('Image slider', [], 'Modules.Imageslider.Admin');
$this->description = $this->trans('Add sliding images to your homepage to welcome your visitors in a visual and friendly way.', [], 'Modules.Imageslider.Admin');
$this->ps_versions_compliancy = ['min' => '1.7.4.0', 'max' => _PS_VERSION_];
$this->ps_versions_compliancy = ['min' => '8.0.0', 'max' => _PS_VERSION_];

@leemyongpakvn leemyongpakvn Aug 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

module version need to be bumped to 4.0.0 accordingly

@rdy4ever rdy4ever Jan 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why break compatibility with 1.7 if nothing in this PR actually needs version 8+?


$this->templateFile = 'module:ps_imageslider/views/templates/hook/slider.tpl';
}
Expand Down Expand Up @@ -480,9 +480,10 @@ protected function _postProcess()
'gif',
'jpeg',
'png',
'webp',
]
) &&
in_array($type, ['jpg', 'gif', 'jpeg', 'png'])
in_array($type, ['jpg', 'gif', 'jpeg', 'png', 'webp'])
) {
$temp_name = tempnam(_PS_TMP_IMG_DIR_, 'PS');
$salt = sha1(microtime());
Expand Down