Add explicit configuration in hooks for missing native modules #904
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,6 +44,7 @@ global_settings: | |
| modules_to_hook: | ||
| displayCustomerAccount: | ||
| - psgdpr | ||
| - ps_emailalerts | ||
| # Keep existing hooks and append them after | ||
| - ~ | ||
| displayNav1: | ||
|
|
@@ -60,35 +61,46 @@ global_settings: | |
| displayTop: | ||
| - ps_mainmenu | ||
| - ps_searchbar | ||
| - pagesnotfound | ||
| # Keep existing hooks and append them after | ||
| - ~ | ||
| displayHome: | ||
| - ps_imageslider | ||
| - ps_featuredproducts | ||
| - ps_banner | ||
| - ps_customtext | ||
|
Contributor
There was a problem hiding this comment.
|
||
| - ps_specials | ||
| - ps_newproducts | ||
| - ps_bestsellers | ||
| # Keep existing hooks and append them after | ||
| - ~ | ||
| displayFooterBefore: | ||
| - ps_socialfollow | ||
| - ps_emailsubscription | ||
| - blockreassurance | ||
| # Keep existing hooks and append them after | ||
| - ~ | ||
| displayFooter: | ||
| - ps_linklist | ||
| - ps_customeraccountlinks | ||
| - ps_contactinfo | ||
| - ps_socialfollow | ||
|
Contributor
There was a problem hiding this comment.
|
||
| # Keep existing hooks and append them after | ||
| - ~ | ||
| displayFooterProduct: | ||
| - productcomments | ||
| - ps_categoryproducts | ||
| - ps_crossselling | ||
| - ps_googleanalytics | ||
|
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment. Its used for tracking I think, but why do we need a non theme module configured here? I dont get it @jolelievre |
||
| - ps_viewedproduct | ||
| # Keep existing hooks and append them after | ||
| - ~ | ||
| displayLeftColumn: | ||
| - ps_categorytree | ||
| - ps_facetedsearch | ||
| - ps_brandlist | ||
|
Contributor
There was a problem hiding this comment.
|
||
| - ps_contactinfo | ||
|
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment. Yes, this should not be there. |
||
| - ps_supplierlist | ||
|
Contributor
There was a problem hiding this comment.
|
||
| # Keep existing hooks and append them after | ||
| - ~ | ||
| displayContactLeftColumn: | ||
|
|
@@ -101,6 +113,7 @@ global_settings: | |
| - ~ | ||
| displayContactContent: | ||
| - contactform | ||
| - ps_contactinfo | ||
|
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment. Yes, |
||
| # Keep existing hooks and append them after | ||
| - ~ | ||
| displaySearch: | ||
|
|
@@ -110,6 +123,8 @@ global_settings: | |
| displayProductAdditionalInfo: | ||
| - ps_sharebuttons | ||
| - productcomments | ||
| - ps_emailalerts | ||
| - ps_viewedproduct | ||
|
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment. This is kinda borderline - the hook is required by this module to be there, it tracks the views there, check the code there. But, does this entry belong to a theme configuration, if it's not visible? Maybe? Or not? I don't really understand the logic of this whole config thing. Yes, a theme should look somehow when it's installed, but it's the module that says what hooks should be where. 🤔 We decide to change hooks in the next module version and we will adapt the theme YML? Hm hm hm.
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment. @tblivet It's there not to display, but to |
||
| # Keep existing hooks and append them after | ||
| - ~ | ||
| displayProductListReviews: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pagesnotfoundI think we don't need this one.