Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Apache Httpd example #1909

Open
wants to merge 2 commits into
base: 8.x
Choose a base branch
from
Open

Update Apache Httpd example #1909

wants to merge 2 commits into from

Conversation

rickygzz
Copy link
Contributor

@rickygzz rickygzz commented Jan 3, 2025 •
edited
Loading

Questions Answers
Branch? 8.x
Description? Moving DocumentRoot to match the second section placement (just before the Directory tag), updated PHP to the recommended 8.3 version and deleting repeated DocumentRoot in the same block.
Fixed ticket? Fixes #{issue number here} if there is a related issue

@github-actions github-actions bot added the 8.x label Jan 3, 2025
@matks matks changed the title Update httpd.md Update Apache Httpd example Jan 3, 2025
matks
matks requested changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, just a little thing to adapt ;)

basics/installation/advanced/httpd.md Outdated Show resolved Hide resolved
@rickygzz @matks
Update httpd.md
d624a1a 
Co-authored-by: Mathieu Ferment <[email protected]>
@rickygzz
Copy link
Contributor Author

rickygzz commented Jan 3, 2025

Thank you! Changed to 8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickygzz @matks