Add explicit configuration in hooks for missing native modules - #190
Closed
jolelievre wants to merge 1 commit into
Closed
Add explicit configuration in hooks for missing native modules#190jolelievre wants to merge 1 commit into
jolelievre wants to merge 1 commit into
Conversation
nicosomb
approved these changes
Jan 19, 2026
mattgoud
approved these changes
Jan 19, 2026
Hlavtox
requested changes
Jan 19, 2026
Hlavtox
left a comment
Contributor
There was a problem hiding this comment.
This doesnt feel right.
Why is viewed products on additional content? pagesnotfound On displaytop? Etc
Contributor
Author
|
@Hlavtox same comment as here PrestaShop/hummingbird#904 (comment) I didin't add anything, these are the hooks that native modules register to, this modification is just highlighting what is already happening when the modules are installed I don't have a case by case answer module by module, you can look into them if you're curious I guess, I simply registered the modules that already register anyway |
Contributor
|
tblivet same here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
~works as expected it's safer to update the configuration with actually expected hooks But we keep the~so this reference module doesn't mess with the shop configuration for tests~value, this modification only is useful when you switch from/to tier party themes