Skip to content

Add explicit configuration in hooks for missing native modules - #190

Closed
jolelievre wants to merge 1 commit into
PrestaShop:developfrom
jolelievre:native-hooks
Closed

Add explicit configuration in hooks for missing native modules#190
jolelievre wants to merge 1 commit into
PrestaShop:developfrom
jolelievre:native-hooks

Conversation

@jolelievre

Copy link
Copy Markdown
Contributor
Questions Answers
Description? Add explicit configuration in hooks for missing native modules, now that we validated that the ~ works as expected it's safer to update the configuration with actually expected hooks But we keep the ~ so this reference module doesn't mess with the shop configuration for tests
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? ~
Sponsor company ~
How to test? Not sure it needs to be tested since we already checked with QA the ~ value, this modification only is useful when you switch from/to tier party themes

@github-project-automation github-project-automation Bot moved this to Ready for review in PR Dashboard Jan 19, 2026
@jolelievre jolelievre added this to the 3.1.0 milestone Jan 19, 2026
@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Jan 19, 2026

@Hlavtox Hlavtox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesnt feel right.

Why is viewed products on additional content? pagesnotfound On displaytop? Etc

@ps-jarvis ps-jarvis moved this from To be tested to Waiting for author in PR Dashboard Jan 19, 2026
@jolelievre

Copy link
Copy Markdown
Contributor Author

@Hlavtox same comment as here PrestaShop/hummingbird#904 (comment)

I didin't add anything, these are the hooks that native modules register to, this modification is just highlighting what is already happening when the modules are installed I don't have a case by case answer module by module, you can look into them if you're curious I guess, I simply registered the modules that already register anyway

@Touxten

Touxten commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

tblivet same here.
But i agree Jo it doesn't change much

@jolelievre jolelievre closed this Jan 20, 2026
@github-project-automation github-project-automation Bot moved this from Waiting for author to Closed in PR Dashboard Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants