Update tab, roles and feature flags related to new Admin API #686
Conversation
|
Hi @jolelievre Thank you for your PR, I tested it and : When I do an upgrade, I don't have the Api automatiquely checked like this PR add it : Except when I do it from a Multistore, the API button for Multistore is checked but not the Initial API, as you can see : recording.176.webmMoreover, When I do the Upgrade and I check the API Feature. I don't have the acces to it on BO as you can see on this screenshot
Tested from When I do It from I have : and when I clic on Authorization server, I have : Even if I enable "Admin API - Enable experimental endpoints" Do you know how to correct this things ? Waiting for feedback |
|
Thanks @AureRita I'll look into it, besides I have conflicts to fix anyway |
|
Is this PR still relevant @jolelievre ? |
|
@kpodemski I think it is, I'll check this tomorrow and update it if necessary |
|
|
Hi @jolelievre Thank you for your PR, I tested your PR again and it seems to have the same behaviour as you can see : recording.315.webmI didn't have the authorization server on the side. Waiting for your feedback |
|
Ping @jolelievre for rebase |
|
Hello @jolelievre! Can you check it? Thanks 👍 |
|
@gericfo yep, I was focused on other tasks but I should have time to look into it today 😉 |
jolelievre
force-pushed
the
admin-api
branch
2 times, most recently
from
3721972 to
f5a1b54
Compare
jolelievre
force-pushed
the
admin-api
branch
14 times, most recently
from
4ca3246 to
1474c30
Compare
jolelievre
force-pushed
the
admin-api
branch
from
1474c30 to
5c87ade
Compare
upgrade/sql/9.0.0.sql
Outdated
| INSERT INTO `PREFIX_feature_flag` (`name`, `type`, `label_wording`, `label_domain`, `description_wording`, `description_domain`, `state`, `stability`) VALUES | ||
| ('admin_api_multistore', 'env,query,dotenv,db', 'Admin API - Multistore', 'Admin.Advparameters.Feature', 'Enable or disable the Admin API when multistore is enabled.', 'Admin.Advparameters.Help', 1, 'beta'), | ||
| ('admin_api_experimental_endpoints', 'env,dotenv,db', 'Admin API - Enable experimental endpoints', 'Admin.Advparameters.Feature', 'Experimental API endpoints are disabled by default in prod environment, this configuration allows to forcefully enable them.', 'Admin.Advparameters.Help', 0, 'beta') |
There was a problem hiding this comment.
Unless there is a problem with this part being higher up (line 294) I think it would be good to merge everything so as not to duplicate and modify the table only once.
|
Authorization serveris renamed toAdmin APIand you can access the page and create API clients There should be one remaingin problem when opening the Swagger doc that's because the symbolic link targetting the required assets is not correctly updated This part is handled in a dedicated PR https://github.com/PrestaShop/autoupgrade/pull/1187/files However, after the upgrade you should check that theAPI resourcesnative module is correctly installed (which can also be seen when you create an API client you can see a list of scopes, without the module there are none)