[NEW UI] before destroy logs viewer #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ga-devfront
commented
Jan 21, 2025
•
ga-devfront
commented
| Questions | Answers |
|---|---|
| Description? | At the end of the execution of a step we can be redirected, if this redirection is fast and the DOM is changed we can have the debounce of the logsViewer which will try to execute a script which no longer has any reason to exist because the element no longer exists. |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | N/A |
| Sponsor company | Your company or customer's name goes here (if applicable). |
| How to test? | You can try the backup task from UI and check the console, without the fix you have an error on console, with the fix all is good ! |
ga-devfront
added
bug
…iggered despite the element being removed from the dom
ga-devfront
force-pushed
the
fix/before-destroy-logs-viewer
branch
from
905f776 to
934ddf9
Compare
|
tblivet
approved these changes
Jan 23, 2025
|
Hello @ga-devfront, I tested your PR on 1788, 804 and 820 and it's good for me! 🎉 Thanks! 1788 to 820 804 to 820 820 to 900 Without PR 820 to 900 |
paulnoelcholot
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.