Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce panes #11

Open
wants to merge 10 commits into
base: reselect2
Choose a base branch
from
Open

introduce panes #11

wants to merge 10 commits into from

Conversation

naw
Copy link

@naw naw commented Nov 7, 2015

@jgautsch

Here is a first stab at adding panes. I think there are several ways it could be improved.

However, the first thing to improve is that it isn't actually memoizing the matchingVisibleTodos for each pane individually --- so if you change the search term in one pane, it recalculates for all panes.

I'm not immediately sure how to build a reselect selector to address this issue. Any ideas?

@naw
Copy link
Author

naw commented Nov 7, 2015

I think this pane PR ties in well with the discussion about global selectors vs. memoized component calculations.

Do you know of a way to calculate and memoize the derived data for each pane using a global selector? To be clear, if one pane changes its searchTerm, that should recalculate and memoize the visibleTodos and matchingTodos for that pane, but not recalculate and memoize for the other panes. Currently this branch is recalculating for all panes whenever a single pane changes.

@jgautsch
Copy link
Member

jgautsch commented Dec 3, 2015

For posterity: This is the good one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants