fix 3.9 specific issues with BackgroundTasks #17326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
added
the
development
CodSpeed Performance ReportMerging #17326 will not alter performanceComparing Summary
|
zzstoatzz
commented
Feb 28, 2025
| "pytz>=2021.1,<2026", | ||
| "readchar>=4.0.0,<5.0.0", | ||
| "sqlalchemy[asyncio]>=2.0,<3.0.0", | ||
| "starlette<0.46.0; python_version == '3.9'", |
cicdw
reviewed
Feb 28, 2025
cicdw
approved these changes
Feb 28, 2025
zzstoatzz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to Kludex/starlette#2812
removes
db_injectorfrom functions that the deployments endpoints was giving toBackgroundTasksnot exactly sure what the offending interaction was, but we want to remove
db_injectoracross the board anywaysthe large diff comes from correctly typing the endpoints with optionals