Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Adds action description for change state of a flow #16799

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UI v2] feat: Adds action description for change state of a flow #16799

wants to merge 1 commit into from
+35 −11

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Jan 21, 2025 •
edited
Loading

  1. Updates Status badge UI component, so that it can be re-used for this automation type. (Should update this component to not expect a State schema, but UI props instead)
  2. Adds action descriptions for change-flow-run-state type

Screenshot 2025-01-21 at 12 29 30 PM

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to: #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Jan 21, 2025
devinvillarosa
devinvillarosa commented Jan 21, 2025
View reviewed changes
ui-v2/src/components/ui/state-badge/index.tsx
@@ -38,12 +38,12 @@ const stateBadgeVariants = cva("gap-1", {

export const StateBadge = ({
state,
}: { state: components["schemas"]["State"] }) => {
}: { state: Omit<components["schemas"]["State"], "id"> & { id?: string } }) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an upcoming PR, I'll update the props to only expect the UI components (type and name).
So that it can be more flexible for other UI patterns

@devinvillarosa devinvillarosa marked this pull request as ready for review January 21, 2025 20:35
@devinvillarosa devinvillarosa force-pushed the add-change-flow-run-state-automation-description branch from 34ca6e1 to e306a89 Compare January 21, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@devinvillarosa