Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Adds action details for work queues and work pools #16784

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UI v2] feat: Adds action details for work queues and work pools #16784

wants to merge 1 commit into from
+120 −96

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Jan 20, 2025 •
edited
Loading

  1. Updates routes to use name for work pools and work queue routes.
  2. Adds action details for work pools and work queues
Screenshot 2025-01-20 at 10 47 28 AM

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Jan 20, 2025
@devinvillarosa devinvillarosa force-pushed the actions-details-work-pools-and-queues branch from 6e8d2be to 7470d56 Compare January 20, 2025 18:50
devinvillarosa
devinvillarosa commented Jan 20, 2025
View reviewed changes
ui-v2/src/storybook/utils/mode-decorator.tsx
@@ -17,7 +17,7 @@ export const ModeDecorator: DecoratorFunction<ReactRenderer> = (Story) => {

return (
<>
<div className="absolute bottom-4 left-4 z-50">
<div className="fixed bottom-4 left-4 z-50">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating positioning because absolute doesn't work well if the story is scrollable

@devinvillarosa devinvillarosa force-pushed the actions-details-work-pools-and-queues branch from 7470d56 to 11797d9 Compare January 20, 2025 18:51
devinvillarosa
devinvillarosa commented Jan 20, 2025
View reviewed changes
ui-v2/src/routes/work-pools/work-pool.$id.tsx Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a redundant file from a bad merge

@devinvillarosa devinvillarosa marked this pull request as ready for review January 20, 2025 18:52
@devinvillarosa devinvillarosa force-pushed the actions-details-work-pools-and-queues branch from 11797d9 to 74a73f9 Compare January 20, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@devinvillarosa