consolidate hook calling in flow engine #16596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
commented
Jan 3, 2025
| @@ -3667,7 +3667,7 @@ def my_flow(): | |||
| await my_flow(return_state=True) | |||
| assert my_mock.mock_calls == [call("crashed")] | |||
|
|
|||
| async def test_on_crashed_hook_not_called_on_sigterm_from_flow_with_cancelling_state( | |||
There was a problem hiding this comment.
the hook actually should run here
zzstoatzz
changed the title
zzstoatzz
force-pushed
the
crash-hook
branch
2 times, most recently
from
c2a9cd9 to
653bc7f
Compare
CodSpeed Performance ReportMerging #16596 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16427
(#16436 is not closed by this, as this is a separate issue)