Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BlockType, BlockDocument, and BlockSchema CRUD methods in client #16587

Merged
merged 27 commits into from
Jan 3, 2025

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented Jan 3, 2025

Related to #16472, this PR continues the optimization pattern established for Artifacts. Like the previous PRs, it:

  • Refactors the client's BlockType, BlockSchema, and BlockDocument CRUD methods into standalone modules
  • Uses ForwardRefs for heavy imports, moving them into the call itself

Copy link

codspeed-hq bot commented Jan 3, 2025

CodSpeed Performance Report

Merging #16587 will not alter performance

Comparing refactor-blocks-client (7712937) with main (5fb0a5a)

Summary

✅ 3 untouched benchmarks

@desertaxle
Copy link
Member

It looks like this PR contains changes included in #16581, so I'm going to hold off on reviewing it until that branch is merged. Feel free to @ me once this PR is ready for review!

@aaazzam aaazzam enabled auto-merge (squash) January 3, 2025 18:14
@aaazzam aaazzam requested a review from desertaxle January 3, 2025 21:11
@aaazzam aaazzam merged commit bce7345 into main Jan 3, 2025
39 checks passed
@aaazzam aaazzam deleted the refactor-blocks-client branch January 3, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants