rm sync_compatible from automations SDK
#16584
Merged
+353
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
requested review from
aaazzam,
cicdw,
desertaxle and
discdiver
as code owners
CodSpeed Performance ReportMerging #16584 will not alter performanceComparing Summary
|
aaazzam
approved these changes
Jan 3, 2025
|
@desertaxle #16583 is merged |
desertaxle
approved these changes
Jan 3, 2025
src/prefect/automations.py
Outdated
| assert name is not None | ||
| automation = await client.read_automations_by_name(name=name) | ||
| if len(automation) > 0: | ||
| return cls(**automation[0].model_dump()) if automation else None |
There was a problem hiding this comment.
Seems like we should be consistent and always raise if the automation is not found. That should help simplify the typing.
There was a problem hiding this comment.
good call, applied in bf22753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #15008