Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Automations CRUD methods in client #16579

Merged
merged 6 commits into from
Jan 3, 2025
Merged

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented Jan 2, 2025

Related to #16472, this PR continues the optimization pattern established for Deployments. Like the previous PRs, it:

Refactors the client's Deployments CRUD methods into a standalone module
Uses ForwardRefs for heavy imports, moving them into the call itself

Copy link

codspeed-hq bot commented Jan 2, 2025

CodSpeed Performance Report

Merging #16579 will not alter performance

Comparing refactor-automations-client (e470227) with main (29d7a48)

Summary

✅ 3 untouched benchmarks

Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after merge conflicts

@aaazzam aaazzam enabled auto-merge (squash) January 3, 2025 02:47
@aaazzam aaazzam merged commit 6076048 into main Jan 3, 2025
38 checks passed
@aaazzam aaazzam deleted the refactor-automations-client branch January 3, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants