This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
use prefect task name as remote function name #103
Merged
desertaxle
merged 6 commits into
PrefectHQ:main
from
j-tr:prefect-task-name-as-ray-renote-function-name
Dec 6, 2023
Merged
use prefect task name as remote function name #103
desertaxle
merged 6 commits into
PrefectHQ:main
from
j-tr:prefect-task-name-as-ray-renote-function-name
Dec 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
j-tr
force-pushed
the
prefect-task-name-as-ray-renote-function-name
branch
2 times, most recently
from
November 14, 2023 09:48
b6f1185
to
eb35669
Compare
j-tr
force-pushed
the
prefect-task-name-as-ray-renote-function-name
branch
from
November 14, 2023 10:03
eb35669
to
4db5c1d
Compare
this looks good to me - thanks a lot |
@PrefectHQ/open-source, sorry to chase, wondering if someone can do a quick review to unblock this? Code looks good and the feature is very nice to have |
@desertaxle it would be great to receive some feedback on this 🙏 |
desertaxle
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but I want to update the changelog entry since we've had a few releases since this PR was initially submitted. Sorry for the review delay and thanks for your patience!
Tests are failing due to a new version of |
desertaxle
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #86
Example
Screenshots
Checklist
pre-commit
checks.pre-commit install && pre-commit run --all
locally for formatting and linting.mkdocs serve
view documentation locally.