Skip to content

fixes #11 --- Polymer 2 - modulesLoaded.some is not a function #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahrobinson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixes #11 --- Polymer 2 - modulesLoaded.some is not a function #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions px-view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
type: Boolean,
value: false
},

/**
*
* Set to true to load this view asynchronously.
Expand Down Expand Up @@ -236,7 +236,7 @@
that.set('status', 'loaded');
} else {
var modulesLoaded = Polymer.dom(that._importLink.import).querySelectorAll('dom-module');
if (modulesLoaded.some(function(ele) {return ele.id === that._elementTagName;})) {
if (Array.prototype.some.call(modulesLoaded, function(ele) {return ele.id === that._elementTagName;})) {
that.set('status', 'loaded');
} else {
console.log('Error: dom-module of imported element does not match element tag name');
Expand Down