Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML: simplify styles for custom ol markers #2377

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

HTML: simplify styles for custom ol markers #2377

wants to merge 2 commits into from

Conversation

jjrsylvestre
Copy link
Contributor

@ascholerChemeketa Can you take a look?

@ascholerChemeketa
Copy link
Contributor

The substance looks good to me on a quick test drive.

As to form, I would recommend:

  • Remove all the changes to anything in css/dist. We are moving towards removing all of those from source control (or at least removing them from the PR process).
  • Drop the update to package-lock.json. (I will look into adding it to git ignore.)
  • Rob usually likes changes to documentation to be in separate commits from changes to the code. Maybe split off the sample-article change into a separate commit.

@ascholerChemeketa ascholerChemeketa mentioned this pull request Jan 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjrsylvestre @ascholerChemeketa