Fix tests and bump packages #5149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerShell 7.5 was released so the update test needed its usual fix. Ironically, OneBranch now uses 7.4 so we can rely on PSResourceGet existing.
There was a problem hiding this comment.
PR Overview
This pull request updates the PowerShell pipeline and unit tests to accommodate changes in PowerShell versions by relying on built‐in PSResourceGet and adjusting version expectations in the tests.
- Update the pipeline script to remove redundant repository registration commands and rely on built-in PSResourceGet.
- Adjust unit tests by updating version details and assertions for both LTS and stable update checks.
Reviewed Changes
| File | Description |
|---|---|
| .pipelines/vscode-powershell-Official.yml | Simplified the installation step by replacing manual module registration with a direct script call. |
| test/features/UpdatePowerShell.test.ts | Updated version details and assertion expectations in multiple test cases to reflect the new PowerShell version bump. |
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
test/features/UpdatePowerShell.test.ts:117
- In the LTS update test, the previous allowance for tag starting with 'v7.2' was removed. Confirm that the new behavior (expecting only tags starting with 'v7.4') is intended given the updated input version.
assert(tag.startsWith("v7.4"));
test/features/UpdatePowerShell.test.ts:131
- The stable update test now expects tags starting with 'v7.5' instead of 'v7.4'. Verify that this change correctly reflects the updated requirements for stable version updates.
assert(tag?.startsWith("v7.5"));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the unit test that needs to be bumped due to PowerShell 7.5 releasing. Fixes the OneBranch pipeline to rely on built-in PSResourceGet now that PowerShell 7.4 is (ironically) finally used. Bumps minor versions of packages automatically and carefully/manually bumps major versions.