Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.24.0: Thanks to all the new contributors! #2084

Merged
merged 2 commits into from
Mar 17, 2025
Merged

v1.24.0: Thanks to all the new contributors! #2084

merged 2 commits into from
Mar 17, 2025

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Mar 14, 2025

@bergmeister and @sdwheeler hoping to get this out on Monday. Need to run this by @SydneyhSmith but thinking we should opt not try doing a preview, as one has never been done before for this module so there's a lot to fix with versioning if we did v1.24.0-preview (and then have to bump to v1.25.0 because some things get confused per @SeeminglyScience).

@bergmeister
Copy link
Collaborator

I was thinking about doing a preview before but in past when we used preview gallery for that purpose, we had only about 10 downloads even after a week. Most folks use PSSA in CI where they will first be hit with the news of a release and later when the vs-code extension consumes it. In my experience the most important aspect of slowly introducing it to users is via the powershell preview vs code extension as there are more users that can give good feedback before deciding to consume new version in stable extension.

@bergmeister
Copy link
Collaborator

bergmeister commented Mar 15, 2025

We need to sync our changes to docs, which I think is just the one in #1704 where UseCorrectCasing had new options added, just noticed by looking at PR again that those new options aren't documented so opened #2086 before doing the sync.

Also, it seems MSDocs changes have not been synced to PSSA so I opened PR #2085

I created a draft release here for now that then will need updating with the final changelog: https://github.com/PowerShell/PSScriptAnalyzer/releases/tag/untagged-b473ea363a2c6ccd71d6

@sdwheeler
Copy link
Collaborator

@andyleejordan Need to merge #2085 and add it to the release

@andyleejordan
Copy link
Member Author

I created a draft release here for now that then will need updating with the final changelog: https://github.com/PowerShell/PSScriptAnalyzer/releases/tag/untagged-b473ea363a2c6ccd71d6

I will not be able to use this as the build/release pipeline must create the draft release itself. Sorry!

@bergmeister
Copy link
Collaborator

I created a draft release here for now that then will need updating with the final changelog: https://github.com/PowerShell/PSScriptAnalyzer/releases/tag/untagged-b473ea363a2c6ccd71d6

I will not be able to use this as the build/release pipeline must create the draft release itself. Sorry!

Gotcha, at least this way it saves on manual synchronisation effort because I was thinking for a moment whether we should stop maintain the changelog md file and just use releases only

@andyleejordan
Copy link
Member Author

I was thinking about doing a preview before but in past when we used preview gallery for that purpose, we had only about 10 downloads even after a week. Most folks use PSSA in CI where they will first be hit with the news of a release and later when the vs-code extension consumes it. In my experience the most important aspect of slowly introducing it to users is via the powershell preview vs code extension as there are more users that can give good feedback before deciding to consume new version in stable extension.

Yeah, that makes sense. Good to know about the low gallery update. I was planning to include it in the next preview of the extension (and would try to get that out ASAP) so we're covered there.

@andyleejordan
Copy link
Member Author

Gotcha, at least this way it saves on manual synchronisation effort because I was thinking for a moment whether we should stop maintain the changelog md file and just use releases only

That's what I've opted to do for other projects. In vscode-powershell for instance I modified the update script to just add:

  1. Header with version and date,
  2. the -Changes submitted when running the script (so a small descriptive sentence or two, also in the commit)
  3. a link to the GitHub release

That way there's no duplication or syncing to do.

@andyleejordan
Copy link
Member Author

@andyleejordan Need to merge #2085 and add it to the release

Merged.

@bergmeister
Copy link
Collaborator

Re-opened #2086 because it seems to have not been included in #2085

Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the outstanding, long suggestion of grouping changes that I just updated, the rest looks all good to me, ready to test a release candidate if the internal build can be shared

@andyleejordan
Copy link
Member Author

Apart from the outstanding, long suggestion of grouping changes that I just updated, the rest looks all good to me, ready to test a release candidate if the internal build can be shared

When I get the pipeline running, if I remember correctly it'll open a draft GitHub release with the module uploaded and then sit and wait for me to allow for it to publish to the gallery. And since you have access to view draft releases, you should be able to download and test it. I'll merge this and get that going.

Co-authored-by: Christoph Bergmeister <[email protected]>
@andyleejordan andyleejordan enabled auto-merge (squash) March 17, 2025 19:59
@andyleejordan andyleejordan disabled auto-merge March 17, 2025 21:16
@andyleejordan andyleejordan merged commit 4b4a136 into main Mar 17, 2025
6 checks passed
@andyleejordan andyleejordan deleted the release branch March 17, 2025 21:16
@andyleejordan
Copy link
Member Author

@bergmeister the draft is up with the 1.24 nupkg, I've got 24 hours to approve its release to the gallery. Let me know before this time tomorrow if you think it's good to go and I'll finish the release and get it out!

@bergmeister
Copy link
Collaborator

@bergmeister the draft is up with the 1.24 nupkg, I've got 24 hours to approve its release to the gallery. Let me know before this time tomorrow if you think it's good to go and I'll finish the release and get it out!

Tested, especially with LTS version (PS 7.4.6), which CI does not cover and all tests passed. 🚢 it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants