Skip to content

Conversation

Jerry-Jinfeng-Guo
Copy link
Member

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo commented Sep 28, 2025

This PR fixes/reconfigures unit/validation test cases for #1136

In the unit test for observability, existing tests are essentially validation tests. There is no presence of real unit test per se. The addition of unit test there is therefore out of the scope.

Signed-off-by: Jerry Guo <[email protected]>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo self-assigned this Sep 28, 2025
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the feature New feature or request label Sep 28, 2025
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo marked this pull request as ready for review September 28, 2025 14:26
…-voltage-phasor' into feature/reconfigure-test-case-for-full-observability-check
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reconfigures test cases for state estimation observability to reflect the implementation of full observability checks for meshed grids. It removes workarounds and expected failures that were in place before the observability feature was fully implemented.

  • Removes xpass configuration that was marking a test as unexpectedly passing
  • Fixes the leaf-without-power-sensor-meshed test case by updating expected output data
  • Removes xfail configuration that was expecting failures due to unimplemented features

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/data/state_estimation/meshed-network-observability/02-unobservable-with-branch-measurement/params.json Removes xpass configuration now that observability check is implemented
tests/data/state_estimation/ill-conditioned-system/leaf-without-power-sensor-meshed/sym_output.json Updates expected output with corrected node data and removes sensor residual fields
tests/data/state_estimation/ill-conditioned-system/leaf-without-power-sensor-meshed/params.json Removes xfail configuration as the bug has been resolved

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@figueroa1395
Copy link
Member

Should we wait until #1136 is merged before merging this one? Good to go in my eyes besides the CI checks (unrelated to this PR itself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants