ci: fix nightly after pandapower 3.2.0 release #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: furqan463 <[email protected]>
nitbharambe
previously approved these changes
Oct 13, 2025
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Pandapower converter: Fix compatibility issues with upcoming pandapower release.
|
nitbharambe
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandapower now has
lxmlas an optional dependency but it's actually not optional because to runimport pandapower.networks, it also first needs to do (inpandapower.__init__.py)from pandapower.run_pp import *, which in turn importspandapower.converter, which useslxml. We do not want to havepandapower[converter]as a PGM dev dependency, as it also imports other things and it doesn't make sense to do so, so here we go.Requires #333 before it can be merged to
main.