Skip to content

fix: hashtables <1.4.1 fail to build with GCC 15 #4315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: hashtables <1.4.1 fail to build with GCC 15 #4315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cabal.project
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@ packages: postgrest.cabal
tests: true
package *
ghc-options: -split-sections

-- avoid hashtables pre-1.4.1 that fail to build with GCC 15; see https://github.com/gregorycollins/hashtables/issues/98
constraints:
hashtables >= 1.4.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line causes rebuilds for Nix, too - which we don't need, because we're not running GCC 15 there, yet.

You can see this in the failing CI jobs:

hashtables-1.4.2 (lib) (requires download & build)

Maybe we should just do something like allow-newer here for it or so. The stack deps are pinned anyway, and Nix could happily use the older version.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe just remove it altogether from cabal.project? next nixpkgs upgrade will either have 1.4.2 since it's next version in stackage or won't build in case of GCC upgrade only and will be fixed subsequently

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if removal works, then yes.

1 change: 1 addition & 0 deletions stack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ nix:
pure: false

extra-deps:
- hashtables-1.4.2@sha256:4940cab94a15d469845ccf5225f9cb3d354c15e8127ebb58425c8b681f7721d9,10386 # fixes build with GCC 15-ish; https://github.com/gregorycollins/hashtables/issues/98 for details
- fuzzyset-0.2.4
- hasql-pool-1.0.1
- jose-jwt-0.10.0
Expand Down
7 changes: 7 additions & 0 deletions stack.yaml.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@
# https://docs.haskellstack.org/en/stable/topics/lock_files

packages:
- completed:
hackage: hashtables-1.4.2@sha256:4940cab94a15d469845ccf5225f9cb3d354c15e8127ebb58425c8b681f7721d9,10386
pantry-tree:
sha256: 65107f0c970351b971ea1f676a5e00b61e37c298a4c83c867d937f2a774501eb
size: 2895
original:
hackage: hashtables-1.4.2@sha256:4940cab94a15d469845ccf5225f9cb3d354c15e8127ebb58425c8b681f7721d9,10386
- completed:
hackage: fuzzyset-0.2.4@sha256:f1b6de8bf33277bf6255207541d65028f1f1ea93af5541b654c86b5674995485,1618
pantry-tree:
Expand Down
Loading