-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: do not retry transactions on any error #4222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: do not retry transactions on any error #4222
Conversation
1afa5fb
to
665f55c
Compare
Should we vendor hasql-notifications for now since there's no response for diogob/hasql-notifications#30 ? I remember we did this before too. It's a single file so no major maintenance problem there IMO. |
We should not vendor it, for two reasons:
|
510cafa
to
ff133bf
Compare
This needs more involved changes in the hsie source code, which can be deferred to later.
ff133bf
to
23426d2
Compare
Thanks for the ping suggestion (I should've done this weeks ago). Changes are now merged and released upstream!
OK, so this would be the only blocker for this PR for now then. Also some |
WIP
Should close #3673.
hasql
version: Add support for hasql 1.9 diogob/hasql-notifications#30