Skip to content

feat: Add tracking of metrics for mailjet hooks #35500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jul 24, 2025

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Jul 23, 2025

Problem

We had an initial implementation of the webhook tracking. This takes it further to also track the appropriate metric to the CH metrics

Changes

  • Fixes it up a bit
  • Sets up a dedicated service
  • Pulls better types from their docs
  • Sets up the code to track the real metric

How did you test this code?

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

@benjackwhite benjackwhite requested a review from a team July 23, 2025 13:13
@benjackwhite benjackwhite marked this pull request as ready for review July 23, 2025 13:13
Base automatically changed from feat/native-email-fn to master July 23, 2025 14:01
# Conflicts:
#	plugin-server/src/cdp/cdp-api.ts
#	plugin-server/src/cdp/services/messaging/email.service.test.ts
#	plugin-server/src/cdp/services/messaging/email.service.ts
#	plugin-server/src/cdp/types.ts
@benjackwhite benjackwhite enabled auto-merge (squash) July 23, 2025 14:05
@benjackwhite benjackwhite merged commit f54ca8d into master Jul 24, 2025
163 of 164 checks passed
@benjackwhite benjackwhite deleted the feat/metric-tracking-mailjet-webhook branch July 24, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants