Langchain model token counting bug fix #268
Open
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For models with reasoning tokens the `_parse_usage` function does not successfully parse Langchain token usage metadata to PostHog.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed token counting for language models with reasoning tokens by enhancing the _parse_usage function in posthog/ai/langchain/callbacks.py to properly handle usage metadata parsing.
- Added fallback paths to check usage information in both
generation_infoandmessageproperties of model responses - Implemented default empty dictionary fallback if neither usage source exists
- Critical fix ensures accurate token counting metrics in PostHog analytics, particularly for models using reasoning tokens
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For models with reasoning tokens, the
_parse_usagefunction in the LangchainCallbackHandlerdoes not successfully parse token usage metadata to PostHog.