feat: event schema types #2445
Open
feat: event schema types #2445
+74
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| export function createTypedEventCapture<Client extends { capture: (event: string, properties?: any) => any }>( | ||
| client: Client | ||
| ): TypedEventCapture<Client> { | ||
| return new Proxy({} as TypedEventCapture<Client>, { |
There was a problem hiding this comment.
logic: Proxy is not supported in IE 11, which is listed in the browserslist. This will cause runtime errors in IE 11 environments when the typed property is accessed.
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/core/src/typed-events.ts
Line: 44:44
Comment:
**logic:** `Proxy` is not supported in IE 11, which is listed in the browserslist. This will cause runtime errors in IE 11 environments when the `typed` property is accessed.
How can I resolve this? If you propose a fix, please make it concise.| client: Client | ||
| ): TypedEventCapture<Client> { | ||
| return new Proxy({} as TypedEventCapture<Client>, { | ||
| get: (_target, eventName: string) => { |
There was a problem hiding this comment.
logic: The eventName parameter should be typed as string | symbol since Proxy get traps can receive Symbols (e.g., for well-known symbols like Symbol.toStringTag). Consider adding a type guard to filter out non-string property keys.
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/core/src/typed-events.ts
Line: 45:45
Comment:
**logic:** The `eventName` parameter should be typed as `string | symbol` since Proxy get traps can receive Symbols (e.g., for well-known symbols like `Symbol.toStringTag`). Consider adding a type guard to filter out non-string property keys.
How can I resolve this? If you propose a fix, please make it concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file