Skip to content

Conversation

@daibhin
Copy link
Contributor

@daibhin daibhin commented Oct 2, 2025

Problem

Changes

Release info Sub-libraries affected

Libraries affected

  • All of them
  • posthog-js (web)
  • posthog-js-lite (web lite)
  • posthog-node
  • posthog-react-native
  • @posthog/react
  • @posthog/ai
  • @posthog/nextjs-config

Checklist

  • Tests for new code
  • Accounted for the impact of any changes across different platforms
  • Accounted for backwards compatibility of any changes (no breaking changes!)
  • Took care not to unnecessarily increase the bundle size

If releasing new changes

  • Ran pnpm changeset to generate a changeset file
  • Added the "release" label to the PR to indicate we're publishing new versions for the affected packages

@daibhin daibhin requested review from a team as code owners October 2, 2025 10:10
@vercel
Copy link

vercel bot commented Oct 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
posthog-js Error Error Oct 2, 2025 10:10am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

📝 No Changeset Found

This PR doesn't include a changeset. A changeset (and the release label) is required to release a new version.

How to add a changeset

Run this command and follow the prompts:

pnpm changeset

Remember: Never use major version bumps for posthog-js as it's autoloaded by clients.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

style={[
styles.button,
{ backgroundColor: appearance.submitButtonColor },
{ backgroundColor: appearance.submitButtonColor, borderRadius: appearance.submitButtonRadius },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Ensure appearance.submitButtonRadius has a fallback value to prevent undefined border radius

Suggested change
{ backgroundColor: appearance.submitButtonColor, borderRadius: appearance.submitButtonRadius },
{ backgroundColor: appearance.submitButtonColor, borderRadius: appearance.submitButtonRadius || 5 },
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/react-native/src/surveys/components/BottomSection.tsx
Line: 24:24

Comment:
**logic:** Ensure `appearance.submitButtonRadius` has a fallback value to prevent undefined border radius

```suggestion
          { backgroundColor: appearance.submitButtonColor, borderRadius: appearance.submitButtonRadius || 5 },
```

How can I resolve this? If you propose a fix, please make it concise.

@marandaneto
Copy link
Member

@daibhin was that a bug? new feat? need some context

@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Collaborator

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants