fix: start request queue when opting in during session #2353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
Size Change: +530 B (+0.01%) Total Size: 5.09 MB
ℹ️ View Unchanged
|
marandaneto
requested review from
a team
and removed request for
marandaneto
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Requesting a review from @robbie-c specifically since he understands cookieless better than the rest of us |
robbie-c
requested changes
Sep 26, 2025
| expect(posthog.sessionRecording).toBeFalsy() | ||
| }) | ||
|
|
||
| it('should restart autocapture after opt_in_capturing in cookieless mode', async () => { |
There was a problem hiding this comment.
I'm confused about whether the bug is related to autocapture not being restarted on opt-in (which is what this is testing), or whether it's related to the request queue not starting (which is the title of this PR).
Is there a link to a ticket somewhere?
| posthog.opt_in_capturing() | ||
|
|
||
| // Autocapture should be restarted immediately after opt-in | ||
| expect(mockStartIfEnabled).toHaveBeenCalledTimes(1) |
There was a problem hiding this comment.
Hmm I don't think this is the right test
This is just testing an implementation detail.
Ideally we would test whether an autocapture event is sent when a simulated click happens
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This might or might not be superseded by #2408. The PR description seems to say it's about the same thing, but the implementation does something different. |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When calling
posthog.opt_in_capturing()the request queue stays paused, so events are not captured until the user reloads/loads a new page.Changes
Added
this._start_queue_if_opted_in()in the workflow that runs when callingposthog.opt_in_capturing()Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file