chore(flags): Remove feature flag payloads from persistence #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already store feature flag details in persistence, so we can calculate payloads from that rather than storing both.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors feature flag payload handling in PostHog's JavaScript SDK by removing redundant storage of payloads in local storage, since they can be derived from existing feature flag details.
- Added
createFeatureFlagDetailsFromLegacyDecideResponsein/src/posthog-featureflags.tsto handle legacy response formats - Modified
getFlagPayloads()to calculate payloads from flag details instead of reading from storage - Made
idfield optional inFeatureFlagMetadatatype in/src/types.tsto support cases where ID isn't available - Updated tests in
/src/__tests__/featureflags.test.tsto verify payload handling through flag details metadata - Added empty
flagsobject todecideResponsemock in/playwright/utils/setup.tsfor testing
6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -1838,6 +1936,7 @@ describe('parseFeatureFlagDecideResponse', () => { | |||
| payload: 300, | |||
There was a problem hiding this comment.
syntax: Duplicate 'payload' property in metadata object
Suggested change
| payload: 300, |
|
Size Change: +1.79 kB (+0.05%) Total Size: 3.63 MB
ℹ️ View Unchanged
|
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already store feature flag details in persistence, so we can calculate payloads from that rather than storing payloads twice. We still store active feature flags as well as calculated flags in persistence and that's probably just fine as the data is a lot less and we use those everywhere.
Changes
This is a refactoring. No behavioral changes other than
$feature_flag_payloadsis no longer stored in local storage.Checklist
Testing
$feature_flag_payloadsno longer is stored in local storage.