-
Notifications
You must be signed in to change notification settings - Fork 50
feat: Add method to wait for feature flag definitions for local evaluation to be loaded. #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
haacked
wants to merge
4
commits into
main
Choose a base branch
from
haacked/445-add-method-for-local-eval-readiness
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a method to wait for local evaluation flags to be loaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR adds asynchronous and synchronous methods for checking local evaluation readiness in the PostHog Node.js client.
- Updated
/posthog-node/src/feature-flags.ts
to emit alocalEvaluationFlagsLoaded
event and implementisLocalEvaluationReady
. - Added
waitForLocalEvaluationReady
with a configurable timeout in/posthog-node/src/posthog-node.ts
. - Enhanced
/posthog-node/test/feature-flags.spec.ts
with tests for flag loading behaviors and edge cases.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Size Change: +685 B (+0.41%) Total Size: 168 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a way for users to determine if feature flag definitions for local evaluation are loaded.
Problem
Fixes #445
Changes
This adds a new
waitForLocalEvaluationReady
method that waits up to 30 seconds (configurable) for local evaluation feature flags to be loaded.true
immediately if flags are already loaded.false
immediately if local evaluation is not enabled.This new method waits for the new
localEvaluationFlagsLoaded
event which is emitted when we retrieve feature flag definitions from the local evaluation endpoint.This PR also adds a synchronous
isLocalEvaluationReady()
method that checks the feature flag poller to see if any flags are loaded.Release info Sub-libraries affected
Bump level
Libraries affected
Changelog notes
waitForLocalEvaluationReady()
method used to wait for local evaluation flags to be loaded.localEvaluationFlagsLoaded
event which is emitted every time local evaluation flags are loaded.isLocalEvaluationReady()
method to quickly check if feature flags are loaded.