feat(server): Send feature flags on event if sendFeatureFlags is set
#302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to the appropriate changelog:
Make sure the entry includes this PR's number. ## Next
- Send feature flags on event if `sendFeatureFlags` is set ([#302](https://github.com/PostHog/posthog-android/pull/302))If none of the above apply, you can opt out of this check by adding |
dustinbyrne
force-pushed
the
feat/send-feature-flags
branch
from
4cbbd0e to
2236ce3
Compare
dustinbyrne
force-pushed
the
feat/local-eval
branch
2 times, most recently
from
8479f0f to
4e410f0
Compare
This cleans things up for future `onlyEvaluateLocally` config and sending feature flags on capture
Deserialization is handled here, paired closely with the Api. This simplifies deserialization in the server SDK.
This brings method coverage to 92% overall, line 85% overall.
It'll automatically clean up in case the developer forgets to call posthog.close()
It's not necessary considering the first request to trigger local evaluation will synchronously retrieve flag definitions if they're not yet loaded.
dustinbyrne
force-pushed
the
feat/local-eval
branch
from
2e90b4e to
887a3cf
Compare
dustinbyrne
force-pushed
the
feat/send-feature-flags
branch
from
2236ce3 to
d40388a
Compare
dustinbyrne
force-pushed
the
feat/local-eval
branch
from
887a3cf to
7489684
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 This branch is a work in progress
💡 Motivation and Context
The
sendFeatureFlagsconfiguration option was not being respected in the server-side SDK. This change makes it functional.💚 How did you test it?
WIP, tests to come
📝 Checklist