Skip to content

fix: remove conflicting abstract method from Extension base class #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieliser merged 1 commit into from
May 27, 2026
Merged

fix: remove conflicting abstract method from Extension base class #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

**Bug Fixes**

- Fixed fatal error when loading v2 extensions caused by conflicting `registered_controllers()` declarations on `PopupMaker\Plugin\Extension`.
- Fixed the "Preview" button in the classic editor not opening popups — a regression introduced in 1.22.0. You can once again preview popups directly from the editor without having to save and view the live page. Thanks to @marklchaves for the fix.
- Fixed missing styles for Popup Maker blocks on the front end in some installs — blocks now render with the correct styling without a console warning about a missing stylesheet.
- Fixed "Disable popup open tracking" privacy setting not being fully respected — with analytics turned off, popup links no longer get tracking parameters appended and click beacons are no longer sent.
Expand Down
9 changes: 2 additions & 7 deletions classes/Plugin/Extension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
/**
* Abstract base class for all Popup Maker extensions.
*
* Override {@see Container::registered_controllers()} in child classes.
*
* @since 1.21.0
*/
abstract class Extension extends Container {
Expand All @@ -36,13 +38,6 @@ public function __construct( $config ) {
$this->core = \PopupMaker\plugin();
}

/**
* Register all controllers.
*
* @return array<string,\PopupMaker\Base\Controller>
*/
abstract protected function registered_controllers();

/**
* Get core plugin instance.
*
Expand Down
Loading