fix(build): use correct output names for tj-actions/changed-files#1167
Merged
Conversation
WalkthroughThe Detect Changes job in the GitHub Actions workflow has updated its output variable names. The changed-files step now exports Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The detect-changes job uses `files_yaml:` which outputs properties
prefixed with the category name (e.g., `php_any_changed`), not just
the category name (e.g., `php`).
Added documentation comments explaining the two tj-actions/changed-files
output patterns used in this workflow:
- `files_yaml:` → outputs are `{category}_any_changed`
- `files:` → outputs are `any_changed` (no prefix)
This was causing all gated jobs to skip because the outputs were
always undefined.
bc4192a to
98c0aa1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI change detection that was causing all gated jobs to skip.
The Bug
The
detect-changesjob usesfiles_yaml:to define multiple file categories. With this configuration,tj-actions/changed-filesoutputs are prefixed with the category name:Why Individual Jobs Are Different
Individual jobs (like
php-quality,js-quality) usefiles:(notfiles_yaml:), which outputs justany_changedwithout a prefix. Both patterns are valid - they just use different configurations.Changes
detect-changesjobTest Plan